Authentication method UI #17838
Draft
Authentication method UI #17838
+986
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
authentication-method-ui
branch
2 times, most recently
from
c243fe7 to
0da3441
Compare
NobodysNightmare
force-pushed
the
wizard-configuration
branch
2 times, most recently
from
2dcffff to
24a9495
Compare
NobodysNightmare
force-pushed
the
authentication-method-ui
branch
from
0da3441 to
5f48105
Compare
The storage view component now has no own "opinion" on the display order and grouping of steps anymore, but will merely reflect the wizard configuration. Changes in the wizard are immediately reflected in the UI as well. Selection of the right components was also extracted into the storage registries. Renamings of existing translations were in most cases avoided, by renaming wizard steps according to existing translations. This made it necessary to unify the instantiation of all components rendered inside the storage view, which was relatively straight-forward for most of them. The OAuthClientFormComponent was challenging, as there was one use case where it needed to be initialized with a client that was not yet assigned to the storage.
NobodysNightmare
force-pushed
the
wizard-configuration
branch
from
24a9495 to
7631dad
Compare
NobodysNightmare
force-pushed
the
authentication-method-ui
branch
from
5f48105 to
113bb8f
Compare
NobodysNightmare
force-pushed
the
wizard-configuration
branch
from
7631dad to
9a5d500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/cross-application-user-integration-stream/work_packages/60154
Merge checklist