Bump TypeScript to 5.5 #17733
Draft
Bump TypeScript to 5.5 #17733
+382
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
As of 5a2a501 we are now importing the actual I18n implementation. Also resolves the following warning: Unable to determine file type from the file extension, defaulting to js.
Allows us to perform plugin symlinking and file generation necessary for bootstapping frontend tests. Based on a standard plugin setup.
Broken with upgrade from v5 to v6. Formly now defines an extra `formly-field` for a given `formly-form` component. See: https://formly.dev/docs/guide/migration#10-formly-root-field
Fixes additional schema warnings.
Updates spec for selector change in 077112d.
Updates spec for store, selector changes in 077112d. Also forces change detection via `ChangeDetectorRef`.
Add stubs for ICKEditor: this works around an issue with the use of dynamic ESM imports in `CKEditorSetupService#load()` not working with our Karma/Webpack configuration.
Replaces deprecated `FormlyTemplateOptions` interface. See: https://formly.dev/docs/guide/migration#ngx-formlycorejson-schema N.B. That further improvements to type safety could be made by extending `IOPFormlyTemplateOptions`, employing discriminating unions.
TypeScript 5.5 introduces syntax checking for regexen. See: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html#regular-expression-syntax-checking
Fixes schema warnings.
Relate to Angular router:
NG0303: Can't bind to 'uiSref' since it isn't a known property of 'a' (used in the 'ScrollableTabsComponent' component template).
NG0303: Can't bind to 'uiParams' since it isn't a known property of 'a' (used in the 'ScrollableTabsComponent' component template).
Match the `node-version` defined in root `package.json` `engines` entry, `.github/workflows/docker.yml` and `docker/ci/Dockerfile`.
Functionality introduced in TypeScript 5.5. See: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-5.html#inferred-type-predicates
myabc
force-pushed
the
housekeeping/bump-typescript-5.5
branch
from
725eb54 to
4574c0d
Compare
| }); | ||
|
|
||
| function generatePluginModule(plugins) { | ||
| const fileRegister = path.join(railsRout, "frontend/src/app/features/plugins/linked-plugins.module.ts"); |
There was a problem hiding this comment.
This code duplicates the plugin linking of
, so it will not test the reality of the build.We can't get rid of the ruby-based building, as plugins might be added by the Gemfile. I'd vote that we either
- use setup-ruby, bundle with cache und use the actual plugin linking code
- accept that plugins are not properly tested in the frontend code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
What are you trying to accomplish?
This PR upgrades TypeScript to 5.5, which enables us to take advantage of improvements to the type checker, as well as RegEx syntax checking. If necessary, this work could be broken out into a separate PR.
Screenshots
What approach did you choose and why?
Merge checklist