-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tests for sharing project queries #16032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Base automatically changed from
implementation/55163-build-sharing-modal
to
release/14.3
July 4, 2024 06:33
app/contracts/queries/projects/project_queries/base_contract.rb
Outdated
Show resolved
Hide resolved
f2d98d1
to
c8c361b
Compare
ed3ed76
to
24ddf90
Compare
ee7ec0b
to
d7c133f
Compare
69efdfd
to
91d5334
Compare
3ba40d8
to
cf3ebd4
Compare
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #15971 adding all the tests
Tests
SharesController
manage_public_project_queries
and not being able to edit ( @aaron-contreras )Found while writing specs
UserDetailsComponent
to be entity specific (current work package specific details don't fit with a non-project scoped resource like a project query)See: https://community.openproject.org/work_packages/55163