Move ProjectQuery model to the main namespace #15983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
klaustopher
force-pushed
the
project-query-model-name
branch
from
38c0ccb to
596a0fb
Compare
aaron-contreras
approved these changes
Jun 27, 2024
|
@ulferts has pointed out that we should probably specify how we want to handle persisted queries in the future: https://community.openproject.org/projects/openproject/work_packages/55991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current place where the model is, we break all sorts of automations that Rails bring us (i.e. automatically building proper routes with
url_for(@project_query). This will become really problematic when implementing sharing #15971.This PR moves the class to the main namespace without any namespacing so it can be accessed like any other model