add protocols to all ports in olm.yaml quickstart

[lgo]

Description of the change:

Adds protocol to all of the ports defined in the `olm.yaml quickstart.

Motivation for the change:

I was setting up OLM with kustomization and ArgoCD, and the ArgoCD was unable to diff or sync due to the lack of protocol on the apiVersion=operators.coreos.com/v1alpha1 verison=ClusterServiceVersion resource. I figured I'd add the protocol to the two Deployment while I'm here anyways.

ComparisonError: Failed to compare desired state to live state: failed to calculate diff: error calculating structured merge diff: error building typed value from config resource: .spec.install.spec.deployments[0].spec.template.spec.containers[0].ports: element 0: associative list with keys has an element that omits key field "protocol" (and doesn't have default value). Retrying attempt #4 at 11:59AM.

As I understand, this is because the CRD doesn't have a default, which is probably another thing that's worth fixing.

Architectural changes:

N/A

Testing remarks:

• I used my forked version and it worked fine with ArgoCD afterwards

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Bug fixes are accompanied by regression test(s)
• e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
• tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
• Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
• Docs updated or added to /doc
• Commit messages sensible and descriptive
• Tests marked as [FLAKE] are truly flaky and have an issue
• Code is properly formatted

[openshift-ci]

Hi @lgo. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[m1kola]

We have broken release automation which I'm trying to fix now. Don't want to add more variables into the mix so putting this on hold for now.

/hold

[m1kola]

/ok-to-test

[lgo]

Hi! Just bumping this as I've recently dusted off trying out OLM again in my homelab and recalled this open PR.

[perdasilva]

/unhold