Fix: UI validation functions #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix name of 'Deep Insights' capability - Set key to 'capabilities' for error logging - Add regex for alternate version format - Change validation flag to use dashes instead of underscores The first two issues I encountered when running the courier against community-operators PRs. The regex is important for versions that use a string after the semver. I also changed the validation CLI flag to use dashes as is the convention for CLI flags.
openshift-ci-robot
added
the
size/XS
kevinrizza
requested changes
Mar 13, 2019
| @@ -59,7 +59,7 @@ def verify(self): | |||
| parser.add_argument('source_dir', help='Path of your directory of yaml ' | |||
| 'files to bundle. Either set this or ' | |||
| 'use the files argument for bundle data.') | |||
| parser.add_argument('--ui_validate_io', | |||
| parser.add_argument('--ui-validate-io', | |||
There was a problem hiding this comment.
This should be a separate pr, since we are introducing a breaking change on a released feature.
| @@ -467,7 +468,7 @@ def get_alm_kinds(alm_examples): | |||
| # capabilities check | |||
| if not is_capability_level(annotations["capabilities"]): | |||
| self._log_error("metadata.annotations.capabilities %s is not a " | |||
| "valid capabilities level", annotations["capability"]) | |||
| "valid capabilities level", annotations["capabilities"]) | |||
| valid = False | |||
|
|
|||
| return valid | |||
There was a problem hiding this comment.
The three changes in this file all seem unrelated. Can you please submit them as separate pull requests?
This was referenced Mar 13, 2019
|
Following @kevinrizza 's suggestion and closing in favor of separate PRs for each change: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two issues I encountered when running the courier against
community-operators PRs.
The regex is important for versions that use a string after the
semver.
I also changed the validation CLI flag to use dashes as is the
convention for CLI flags. If using underscores was intended I can remove this change.