-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support private quay instance #171
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,14 +21,20 @@ class PushCmd(): | |
def __init__(self): | ||
pass | ||
|
||
def push(self, bundle_dir, namespace, repository, release, auth_token): | ||
def push(self, bundle_dir, namespace, repository, release, auth_token, | ||
quay_host, verify_host): | ||
"""Push takes a bundle and pushes it to the specified app registry repository. | ||
|
||
:param bundle_dir: Path to generated local directory that contains the bundle. | ||
:param namespace: Namespace that contains the repository for the application. | ||
:param repository: Repository name of the application described by the bundle. | ||
:param release: Release version of the bundle. | ||
:param auth_token: Authentication token used to push to Quay.io. | ||
:param quay_host: Can be 'quay.io' or your private instance hostname. | ||
:param verify_host: Either a boolean, in which case it controls whether we verify | ||
the server's TLS certificate, or a string, in which case | ||
it must be a path to a CA bundle to use. | ||
Defaults to ``True``. | ||
""" | ||
logger.info('Generating 64 bit bundle and pushing to app registry.') | ||
filterOutFiles(bundle_dir, BLACK_LIST) | ||
|
@@ -45,14 +51,16 @@ def _create_base64_bundle(self, bundle_dir, repository): | |
result64 = base64.b64encode(result).decode("utf-8") | ||
return result64 | ||
|
||
def _push_to_registry(self, namespace, repository, release, bundle, auth_token): | ||
push_uri = 'https://quay.io/cnr/api/v1/packages/%s/%s' % (namespace, repository) | ||
def _push_to_registry(self, namespace, repository, release, bundle, auth_token, | ||
quay_host, verify_host): | ||
push_uri = 'https://%s/cnr/api/v1/packages/%s/%s' % (quay_host, namespace, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we are going to do this, rather than just support additional
|
||
repository) | ||
logger.info('Pushing bundle to %s' % push_uri) | ||
headers = {'Content-Type': 'application/json', 'Authorization': auth_token} | ||
json = {'blob': bundle, 'release': release, "media_type": "helm"} | ||
|
||
try: | ||
r = requests.post(push_uri, json=json, headers=headers) | ||
r = requests.post(push_uri, json=json, headers=headers, verify=verify_host) | ||
except requests.RequestException as e: | ||
msg = str(e) | ||
logger.error(msg) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just below this, don't you also need to update the call to
_push_to_registry()
to actually pass the new parameters along?