Skip to content

⚠ Modify CE API to support non-catalog installs #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

varshaprasad96
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Varsha Prasad Narsing <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e550063
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6666fab1ce730a000820588a
😎 Deploy Preview https://deploy-preview-917--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@varshaprasad96
Copy link
Member Author

Note: The other parts of the repository are not fixed yet, which is why the tests fail. It is intentional, to first get a green signal on the API change. This is similar to the extension API we had and addresses #747

@varshaprasad96
Copy link
Member Author

Closing this PR for now, since supporting direct installs is not a priority now - at least for OLM v1.0.0 cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant