🌱 Move Registry YAML and remove use of namespace in kustomizations #2088
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
- Coverage 73.52% 73.52% -0.01%
==========================================
Files 78 78
Lines 7241 7240 -1
==========================================
- Hits 5324 5323 -1
Misses 1566 1566
Partials 351 351
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Todd Short <[email protected]>
Currently, the e2e registry resources are located in a script `testdata/build-test-registry.sh` The resources in this script can be moved the the e2e config and manifests that now exist. The only thing that remains is the job, that kinda-sorta needs to wait until the registry is up and working. Signed-off-by: Todd Short <[email protected]>
tmshort
force-pushed
the
move-registry-yaml
branch
from
5c0b959 to
427a442
Compare
| @@ -1,7 +1,6 @@ | |||
| # Does not include the CRD, which must be added separately (it's non-namespaced) | |||
| apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
| namespace: olmv1-system | |||
There was a problem hiding this comment.
So, if we need to change the name, do we have to update all the files after this change?
Also, I haven't checked, but in the downstream setup, are we using a shell script to make the change, or are we properly setting the Kustomize value and then building?
Move e2e registry resources into config
Currently, the e2e registry resources are located in a script
testdata/build-test-registry.shThe resources in this script can be moved the the e2e config and manifests that now exist.
The only thing that remains is the job, that kinda-sorta needs to wait until the registry is up and working.
This requires removing the use of
namespacein kustomize, because it behaves oddly when components and overlays use it.Description
Reviewer Checklist