Skip to content

🌱 migrate from github.com/everettraven/crd-diff to sigs.k8s.io/crdify #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

everettraven
Copy link
Contributor

Description

This updates the usage of github.com/everettraven/crd-diff in CI to sigs.k8s.io/crdify as the project has now been donated under the umbrella of sig-api-machinery.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@everettraven everettraven requested a review from a team as a code owner June 4, 2025 18:30
Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit cfb911f
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/684090cda03d2d00085b77f1
😎 Deploy Preview https://deploy-preview-2010--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +1 to +5
validations:
- name: enum
enforcement: Error
configuration:
additionPolicy: Allow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: This is technically a less restrictive config than existed before, but IIRC it was planned to add new enum values in various places during continued development of OLMv1 so this felt reasonable to include.

If you want to maintain the strictest possible configuration, the options here could be to:

  • Remove the use of a configuration file as crdify defaults to the strictest possible analysis
  • Switch additionPolicy to Disallow (keeps the config file around)

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.17%. Comparing base (8f81c23) to head (cfb911f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2010   +/-   ##
=======================================
  Coverage   69.17%   69.17%           
=======================================
  Files          79       79           
  Lines        7037     7037           
=======================================
  Hits         4868     4868           
  Misses       1887     1887           
  Partials      282      282           
Flag Coverage Δ
e2e 43.00% <ø> (ø)
unit 60.06% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort added the do-not-merge/new-go-version Changes that require a go update. label Jun 4, 2025
@perdasilva
Copy link
Contributor

@everettraven because this pulls in go1.24, we won't be able to merge it T_T

@everettraven
Copy link
Contributor Author

@perdasilva I noted that in a Slack message I sent to the olm-dev channel :)

I imagine that you'll be bumping to go 1.24 at some point? I'm happy for this to be held until that point. I don't think this is urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/new-go-version Changes that require a go update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants