Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix upgrade-e2e, use updated upload-artifact #1649

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jan 23, 2025

Replace cytopia/upload-artifact-retry-action with actions/upload-artifact

This is the same action that e2e-kind uses

cytopia/upload-artifact-retry-action uses an out-of-date upload-artifact action, and has been stale since Nov 2022

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Replace cytopia/upload-artifact-retry-action with actions/upload-artifact

This is the same action that e2e-kind uses

cytopia/upload-artifact-retry-action uses an out-of-date upload-artifact
action, and has been stale since Nov 2022

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner January 23, 2025 20:48
Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 37bce82
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6792ab1b5f73750008399558
😎 Deploy Preview https://deploy-preview-1649--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@grokspawn grokspawn enabled auto-merge January 23, 2025 20:49
@grokspawn grokspawn added this pull request to the merge queue Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.42%. Comparing base (a19f91a) to head (37bce82).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files          55       55           
  Lines        4632     4632           
=======================================
  Hits         3123     3123           
  Misses       1284     1284           
  Partials      225      225           
Flag Coverage Δ
e2e 53.21% <ø> (-0.09%) ⬇️
unit 54.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
Merged via the queue into operator-framework:main with commit c1a8f7d Jan 23, 2025
22 checks passed
@tmshort tmshort deleted the artifacst4 branch January 23, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants