Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump containers/image to v5.33.0 #1620

Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Jan 15, 2025

Description

The latest version of containers/image contains changes to the error handling when loading the default policy file. It no longer returns a file not found error.

⚠️ it seems we have a security issue here as we silently load an insecure default policy.

I've created a tracking issue for this: #1622

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f7a3c6d
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67879626b59f000008f37e3d
😎 Deploy Preview https://deploy-preview-1620--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@perdasilva perdasilva force-pushed the bump/containers/images branch 2 times, most recently from 55fa2e2 to d8f7169 Compare January 15, 2025 10:04
@perdasilva perdasilva marked this pull request as ready for review January 15, 2025 10:06
@perdasilva perdasilva requested a review from a team as a code owner January 15, 2025 10:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
@perdasilva perdasilva changed the title 🌱 bump containers/images to v5.33.0 🌱 bump containers/image to v5.33.0 Jan 15, 2025
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the bump/containers/images branch from d8f7169 to f7a3c6d Compare January 15, 2025 11:04
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.69%. Comparing base (2c8e3b9) to head (f7a3c6d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
catalogd/internal/source/containers_image.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1620   +/-   ##
=======================================
  Coverage   66.68%   66.69%           
=======================================
  Files          57       57           
  Lines        4584     4588    +4     
=======================================
+ Hits         3057     3060    +3     
- Misses       1302     1303    +1     
  Partials      225      225           
Flag Coverage Δ
e2e 52.66% <100.00%> (+0.02%) ⬆️
unit 53.63% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@camilamacedo86 camilamacedo86 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into operator-framework:main with commit baecd3b Jan 15, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants