-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 increase eventually timeout to reduce false negatives #1619
🐛 increase eventually timeout to reduce false negatives #1619
Conversation
Signed-off-by: Per Goncalves da Silva <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 66.68% 66.68%
=======================================
Files 57 57
Lines 4584 4584
=======================================
Hits 3057 3057
Misses 1302 1302
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
From what I can see there was actually already a PR created by @camilamacedo86 to do this but it was closed because the consensus was to do a deeper investigation and try to fix the underlying problem. Having said that, I notice that those failures are getting more and more common, so from my POV it might be a good idea to have the timeout increased until proper fix is in place. |
Thanks for that! Let's see what the team reckons. Maybe we could create a tracking issue, though then we lose the forcing function to RC... |
Moving to draft to block merging until we have a wider discussion with the community/team |
Hi @perdasilva Yep, we have the issue for it already: #1550 So, I would suggest we close this one until the analysis/issue be addressed. WDYT? |
Description
I've been noticing a few false negatives on the upgrade-e2e. Increasing the eventually timeout to see if that helps reduce the incidence.
Reviewer Checklist