chore: update to josdk v5.0.0-beta1 and fabric8-client v7.0.0 and related fixes #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0.0 and related fixes
ebma16
changed the title
csviri
reviewed
Dec 10, 2024
starter/pom.xml
Outdated
| @@ -115,5 +115,11 @@ | |||
| <artifactId>jenvtest-fabric8-client-support</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
When building the project locally from scratch, I noticed some compilation errors, as the import of jetbrains annotations was not working without this dependency.
There was a problem hiding this comment.
could you pls try to remove it and see if it fails on CI here?
There was a problem hiding this comment.
There was a problem hiding this comment.
annotation removed -> CI is successful again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update josdk-spring-boot-starter for compatibility with josdk v5.0.0-beta1 and fabric8 kubernetes-client v7.0.0