normalize unit test targets across repos. add skip/target test args #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: grokspawn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
=======================================
Coverage 38.27% 38.27%
=======================================
Files 56 56
Lines 5450 5450
=======================================
Hits 2086 2086
Misses 3212 3212
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grokspawn
requested review from
Copilot
and removed request for
tmshort and
exdx
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this standardizes the v0 repos so we can do
make unitin all three to perform unit tests. This avoid cognitive dissonance of wondering how each handles it. Preserves the old mechanics in case things are dependent on them.Enhances the unit test runs to generate coverage info by default, and to provide the capability to target or skip specific tests.
In future, I'd really like to get the CI workflows to use the
make unittarget instead of the current hardcoded approach and this is a first step to making that possible.