New dockerfile that can build by itself #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesselang
approved these changes
Apr 18, 2017
Dockerfile
Outdated
| WORKDIR /gopath/src/github.com/operable/go-relay | ||
| COPY . /gopath/src/github.com/operable/go-relay | ||
|
|
||
| RUN apk -U add \ |
There was a problem hiding this comment.
It's common to use apk -U add --virtual .build_deps <packages> followed by apk del .build_deps && rm -rf /var/cache/apk/* Not sure if that would help squeeze anything more out of the image.
There was a problem hiding this comment.
@jesselang I'll go ahead and add the virtual package if for no other reason than to promote good patterns via copy and paste 😄
I'd forgotten about removing the APK cache; I'll give that a try this evening and see if it helps. Either way, I'll merge it afterward.
Thanks for the review!
Previously, we'd build a glibc Relay locally and then stuff that into a minimal Docker image and provide that. Now, we do the build of Relay inside the image build itself. I have confirmed that an executable built in this Alpine image runs fine in a Debian (i.e., glibc) system. However, this results in a larger image size right now. Compare the previous sizes to what is currently built by this commit: | Image | Compressed | Uncompressed | | -------- | ---------- | ------------ | | Previous | 6 MB | 19.9 MB | | Current | 30 MB | 81.6 MB | This allows us to easily automate the build with DockerHub, though, because it doesn't require anything besides the Dockerfile. See operable/cog#1384 for more.
christophermaier
force-pushed
the
cm/consolidate-dockerfile
branch
from
09ff8bf
to
8eb92aa
Compare
|
@jesselang That shaved off another ~0.8MB, so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd build a glibc Relay locally and then stuff that into a
minimal Docker image and provide that. Now, we do the build of Relay
inside the image build itself. I have confirmed that an executable built
in this Alpine image runs fine in a Debian (i.e., glibc) system.
However, this results in a larger image size right now. Compare the
previous sizes to what is currently built by this commit:
This allows us to easily automate the build with DockerHub, though,
because it doesn't require anything besides the Dockerfile.
See operable/cog#1384 for more.