fixes and enhancements #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rgallettonf
reviewed
Aug 2, 2024
...console-lib/src/lib/features/visualizer/network-visualizer/network-visualizer.component.scss
Outdated
Show resolved
Hide resolved
rgallettonf
reviewed
Aug 2, 2024
| @@ -115,7 +115,7 @@ select { | |||
|
|
|||
| #ClearSearchFilter { | |||
| position: absolute; | |||
| right: 2px; | |||
| right: -45px; | |||
There was a problem hiding this comment.
Negative orientation for left/right styling is also an anti-pattern. Usually indicates a larger issue with the layout of the elements container.
There was a problem hiding this comment.
will address in my next PR
rgallettonf
reviewed
Aug 2, 2024
...console-lib/src/lib/features/visualizer/network-visualizer/network-visualizer.component.scss
Outdated
Show resolved
Hide resolved
* Updated tooltip popup to align name/value pairs * Updated clickable node legend icon * Removed "results warning" component * updated coloring for background grid
rgallettonf
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
page Style changes (page background colour, gradient, Font size, Filter text box background color, Input box size increase).
Promises code fix to execute asynchronous execution.
reset tree to close all opened nodes.
Code Cleanup:
removed unused code. Example: drawGraphTooltip function.
appwan name modified to service policies.
Enhancements:
added config class to show configs to a service
show service config in the tooltip
Service policy node —> added promises/api code to show Dial Services
Service —> fixed defect in Bind Identities logic
added promises/api code to show Associated Routers
added promises/api code to show Service Configs
added promises/api code to show Dial Identities
Identities —> added promises/api code to show Associated Routers
added promises/api code to show Bind Services
added promises/api code to show Dial Services
Router Policies —> added promises/api code to show Associated Routers
Search feature enhancements:
In the new design, the visualizer can fetch a maximum of 1000 objects per network component. Whenever there are more than 1000 objects, we will show visualizer with the total object count for each node, the user can use the search feature to pull them based on filter criteria. Although the search API returned hundreds of records based on the filter text, the autocomplete list will only display the top five records.. ex: search word:'ha', result: top 5 of 362 records.