Skip to content

Conversation

anodos325
Copy link
Contributor

MS-FSCC 2.6 is the governing document for DOS attribute behavior.
It specifies the following:

For a file, applications can read the file butcannot write to it or delete it. For a directory,
applications cannot delete it, but applications can create and delete files from the directory.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

MS-FSCC 2.6 is the governing document for
DOS attribute behavior. It specifies the following:

For a file, applications can read the file but
cannot write to it or delete it. For a directory,
applications cannot delete it, but applications can
create and delete files from the directory.

Signed-off-by: Andrew Walker <[email protected]>
Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks right, but it took a moment to understand that you're just bringing it into alignment with the FreeBSD code. It'd be good for the commit message to reflect that.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 13, 2025
@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 17, 2025
@amotin amotin merged commit 783a02b into openzfs:master Oct 20, 2025
23 of 25 checks passed
@amotin amotin deleted the fix-zfs-readonly branch October 20, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants