Skip to content

dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error #17353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error #17353

merged 1 commit into from
May 20, 2025

Conversation

@ryao
Copy link
Contributor

@ryao ryao commented May 19, 2025

Motivation and Context

This was caught when doing a manual check to see if #17352 needed to be improved to catch mismatches across stack frames of the kind that were first found in #17340.

Description

We replace dsl_dataset_rele() with dsl_dataset_rele_flags()

How Has This Been Tested?

The fix is trivial. The buildbot can test it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ryao
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
73f7008 
This was caught when doing a manual check to see if openzfs#17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in openzfs#17340.

Signed-off-by: Richard Yao <[email protected]>
@ryao ryao mentioned this pull request May 19, 2025
Closed
13 tasks
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label May 20, 2025
@behlendorf behlendorf merged commit 83fa80a into openzfs:master May 20, 2025
24 checks passed
robn pushed a commit to robn/zfs that referenced this pull request May 23, 2025
@ryao @robn
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
2f419f0 
This was caught when doing a manual check to see if openzfs#17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in openzfs#17340.

Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#17353
(cherry picked from commit 83fa80a)
(cherry picked from commit 07d815f)
robn pushed a commit to robn/zfs that referenced this pull request May 23, 2025
@ryao @robn
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
88861c5 
This was caught when doing a manual check to see if openzfs#17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in openzfs#17340.

Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#17353
(cherry picked from commit 83fa80a)
(cherry picked from commit 07d815f)
robn pushed a commit to robn/zfs that referenced this pull request May 23, 2025
@ryao @robn
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
07d815f 
This was caught when doing a manual check to see if openzfs#17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in openzfs#17340.

Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#17353
(cherry picked from commit 83fa80a)
@robn robn mentioned this pull request May 23, 2025
Closed
14 tasks
robn pushed a commit to robn/zfs that referenced this pull request May 24, 2025
@ryao @robn
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
ca4d284 
This was caught when doing a manual check to see if openzfs#17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in openzfs#17340.

Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#17353
(cherry picked from commit 83fa80a)
tonyhutter pushed a commit that referenced this pull request May 27, 2025
@ryao @tonyhutter
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
827fd20 
This was caught when doing a manual check to see if #17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in #17340.

Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes #17353
(cherry picked from commit 83fa80a)
(cherry picked from commit 07d815f)
tonyhutter pushed a commit that referenced this pull request May 28, 2025
@ryao @tonyhutter
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
25ad9ce 
This was caught when doing a manual check to see if #17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in #17340.

Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes #17353
(cherry picked from commit 83fa80a)
@IvanVolosyuk IvanVolosyuk mentioned this pull request Jun 15, 2025
Closed
spauka pushed a commit to spauka/zfs that referenced this pull request Aug 30, 2025
@ryao @spauka
dmu_objset_hold_flags() should call dsl_dataset_rele_flags() on error
49e6936 
This was caught when doing a manual check to see if openzfs#17352 needed to be
improved to catch mismatches across stack frames of the kind that were
first found in openzfs#17340.

Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#17353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

+1 more reviewer

@gamanakis gamanakis gamanakis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryao @behlendorf @amotin @gamanakis