Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Remove TXG_TIMEOUT from dedup_quota test #17150

Merged
merged 1 commit into from
Mar 17, 2025
Merged

ZTS: Remove TXG_TIMEOUT from dedup_quota test #17150

merged 1 commit into from
Mar 17, 2025

Conversation

amotin
Copy link
Member

@amotin amotin commented Mar 14, 2025

It seems fio in ddt_dedup_vdev_limit overwhelms the system with the amount of dirty data caused by DDT updates within one TXG due to tiny 1KB records used, while I see no reason for this test to extend the TXGs beyond default.

How Has This Been Tested?

Run full CI sweep in personal repository without any errors from dedup_quota.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
ZTS: Remove TXG_TIMEOUT from dedup_quota test
2f1cb63 
It seems `fio` in `ddt_dedup_vdev_limit` overwhelms the system
with the amount of dirty data caused by DDT updates within one
TXG due to tiny 1KB records used, while I see no reason for this
test to extend the TXGs beyond default.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin amotin requested review from pcd1193182 and allanjude March 14, 2025 19:45
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Mar 14, 2025
@tonyhutter tonyhutter merged commit 21850f5 into openzfs:master Mar 17, 2025
23 of 25 checks passed
@amotin amotin deleted the dedup_to branch March 17, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanjude allanjude allanjude approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

@ImAwsumm ImAwsumm ImAwsumm approved these changes

@pcd1193182 pcd1193182 Awaiting requested review from pcd1193182

Assignees
No one assigned
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amotin @allanjude @tonyhutter @ImAwsumm