Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check portable objset MAC even if local is zeroed #17122

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Check portable objset MAC even if local is zeroed #17122

merged 1 commit into from
Mar 9, 2025

Conversation

amotin
Copy link
Member

@amotin amotin commented Mar 6, 2025

PR #14161 made spa_do_crypt_objset_mac_abd() to ignore MAC errors if local MAC can not be calculated at the time. But it does not mean we should also ignore portable MAC errors there.

How Has This Been Tested?

It wasn't. I was just reading the code in context of #12014. Lets see if the test introduced in #14161 still pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
Check portable objset MAC even if local is zeroed
27fedf3 
PR openzfs#14161 made spa_do_crypt_objset_mac_abd() to ignore MAC errors
if local MAC can not be calculated at the time.  But it does not
mean we should also ignore portable MAC errors there.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
@amotin
Copy link
Member Author

amotin commented Mar 6, 2025

@rincebrain ^^^

@amotin amotin requested review from behlendorf and tonyhutter March 6, 2025 17:59
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Mar 6, 2025
@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 9, 2025
@amotin amotin merged commit fe67499 into openzfs:master Mar 9, 2025
24 of 25 checks passed
@amotin amotin deleted the local_mac branch March 9, 2025 02:15
pcd1193182 pushed a commit to KlaraSystems/zfs that referenced this pull request Mar 24, 2025
@amotin
Check portable objset MAC even if local is zeroed
3afa46e 
PR openzfs#14161 made spa_do_crypt_objset_mac_abd() to ignore MAC errors
if local MAC can not be calculated at the time.  But it does not
mean we should also ignore portable MAC errors there.

Reviewed-by: Tony Hutter <[email protected]>
Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes openzfs#17122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

@behlendorf behlendorf Awaiting requested review from behlendorf

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotin @tonyhutter