fix: ensure hub leader configmap is deleted with nodepool #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnsimon
changed the title
tnsimon
force-pushed
the
delete-hubleader-config
branch
from
1dfc50f to
9dda519
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
+ Coverage 45.60% 45.74% +0.13%
==========================================
Files 398 393 -5
Lines 26331 25835 -496
==========================================
- Hits 12009 11818 -191
+ Misses 13144 12877 -267
+ Partials 1178 1140 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
reviewed
Feb 15, 2025
rambohe-ch
reviewed
Feb 15, 2025
pkg/yurtmanager/controller/hubleaderconfig/hubleaderconfig_controller.go
Outdated
Show resolved
Hide resolved
tnsimon
force-pushed
the
delete-hubleader-config
branch
2 times, most recently
from
59cdd20 to
d5d4fa1
Compare
tnsimon
force-pushed
the
delete-hubleader-config
branch
from
d5d4fa1 to
61f9054
Compare
|
rambohe-ch
approved these changes
Feb 17, 2025
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Hub leader config should be deleted when nodepool is deleted
Which issue(s) this PR fixes:
Fixes #2323
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?
other Note