Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename crd category from all to yurt #2320

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

luc99hen
Copy link
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

fix issue #2318

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

assign @rambohe-ch @zyjhtangtang

Does this PR introduce a user-facing change?


other Note

@luc99hen luc99hen requested a review from a team as a code owner February 13, 2025 11:35
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (2a40449) to head (67c8f8a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
+ Coverage   45.60%   45.70%   +0.09%     
==========================================
  Files         398      394       -4     
  Lines       26327    25953     -374     
==========================================
- Hits        12006    11861     -145     
+ Misses      13143    12946     -197     
+ Partials     1178     1146      -32     
Flag Coverage Δ
unittests 45.70% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

@luc99hen please fix errors of CI pipeline.

- 将 CRD 的 categories 从 "all" 修改为 "yurt",以更好地组织 OpenYurt 资源
- 移除了 YurtAppDaemon 相关的控制器和类型定义
- 更新了所有受影响的 CRD 文件和 Go 源码文件
@luc99hen
Copy link
Member Author

@luc99hen please fix errors of CI pipeline.

Done!

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Feb 18, 2025
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit f6b8aad into openyurtio:master Feb 18, 2025
14 checks passed
@rambohe-ch
Copy link
Member

Fixes #2318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants