Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade crd in the initContainer #2076

Closed

Conversation

vie-serendipity
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

For now, it's hard to upgrade CRDs because helm can't do this. So we can upgrade CRDs in the initContainer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vie-serendipity vie-serendipity marked this pull request as ready for review June 17, 2024 07:39
@vie-serendipity vie-serendipity changed the title Feat: upgrade crd in the initContainer feat: upgrade crd in the initContainer Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.03%. Comparing base (3713163) to head (8c2ed31).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   56.09%   56.03%   -0.07%     
==========================================
  Files         186      186              
  Lines       18092    18091       -1     
==========================================
- Hits        10149    10137      -12     
- Misses       6910     6921      +11     
  Partials     1033     1033              
Flag Coverage Δ
unittests 56.03% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vie-serendipity
Copy link
Contributor Author

It might not be appropriate to upgrade CRDs in the community, as detailed in the documentation. Refer to the docs for more info openyurtio/openyurt.io#434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant