PR #16921: [PJRT:GPU] Treat GPU collective memory space as device memory space #17030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_672618973
branch
14 times, most recently
from
36b2d0e
to
348d7f4
Compare
…ory space Imported from GitHub PR #16921 This is a regression fix when using --xla_gpu_enable_nccl_user_buffers=true. Return device memory space when collective memory space is used as an output on GPU. Copybara import of the project: -- 8113e6f by Jane Liu <[email protected]>: Treat collective memory space as device memory space when using as an output -- b5e43d6 by Jane Liu <[email protected]>: fix the test Merging this change closes #16921 COPYBARA_INTEGRATE_REVIEW=#16921 from zhenying-liu:nccl-buffer-output b5e43d6 PiperOrigin-RevId: 674073363
copybara-service
bot
force-pushed
the
test_672618973
branch
from
348d7f4
to
c5346ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16921: [PJRT:GPU] Treat GPU collective memory space as device memory space
Imported from GitHub PR #16921
This is a regression fix when using --xla_gpu_enable_nccl_user_buffers=true.
Return device memory space when collective memory space is used as an output on GPU.
Copybara import of the project:
--
8113e6f by Jane Liu [email protected]:
Treat collective memory space as device memory space when using as an output
--
b5e43d6 by Jane Liu [email protected]:
fix the test
Merging this change closes #16921
FUTURE_COPYBARA_INTEGRATE_REVIEW=#16921 from zhenying-liu:nccl-buffer-output b5e43d6