apfree-wifidog: update to 7.10.2082 #25181
Conversation
| GatewayChannel $gateway_channel | ||
| GatewayID $gateway_id | ||
| }" >> ${CONFIGFILE} | ||
| local section="$1" |
There was a problem hiding this comment.
Please use tabs for indentation as always.
liudf0716
force-pushed
the
wifidogx-master
branch
from
9d4486b
to
6409b94
Compare
|
so what you did is clearly more than just "support local auth". please also do not mix irrelevant changes, e.g. the indentation fix should be done in your first commit. |
- Refactored wifidogx.init to improve code structure and readability. - Added local authentication support, allowing authentication without a server. Signed-off-by: Dengfeng Liu <[email protected]>
liudf0716
force-pushed
the
wifidogx-master
branch
from
6409b94
to
0013771
Compare
@1715173329 Refactoring – The init file was restructured to improve code organization and maintainability. |
| @@ -27,7 +27,7 @@ define Package/apfree-wifidog | |||
| SUBMENU:=Captive Portals | |||
| SECTION:=net | |||
| CATEGORY:=Network | |||
| DEPENDS:=+zlib +libjson-c +libevent2 +libevent2-openssl +libuci +openssl-util +libnetfilter-queue | |||
| DEPENDS:=+zlib +libjson-c +libevent2 +libevent2-openssl +libuci +openssl-util +libnetfilter-queue +conntrack +libmosquitto | |||
There was a problem hiding this comment.
I guess these are part of the update, but please mention them in the commit message.
There was a problem hiding this comment.
@1715173329
Conntrack was utilized to fix a bug in Apfree-Wifidog, where a user's long-lived connection persisted even after logging out.
Libmosquitto was integrated as a preparatory step toward future MQTT protocol support, though the implementation is not yet complete.
For more detailed information, please refer to the release notes included in this PR.
https://github.com/liudf0716/apfree-wifidog/releases/tag/7.10.2082
Thank you for the thorough code review!
There was a problem hiding this comment.
Please mention these changes in commit message, thanks.
| @@ -60,6 +60,7 @@ define Package/apfree-wifidog/install | |||
| $(INSTALL_BIN) ./files/wifidogx.init $(1)/etc/init.d/wifidogx | |||
| $(INSTALL_DIR) $(1)/etc/config | |||
| $(CP) ./files/wifidogx.conf $(1)/etc/config/wifidogx | |||
| $(INSTALL_DIR) $(1)/etc/wifidogx | |||
There was a problem hiding this comment.
I apologize for any confusion caused by the new directory '/etc/wifidogx.' This directory is intended to store the local portal page for local authentication when it is enabled. However, maybe it is not the appropriate location for holding the local portal page.
Update Makefile to include dependencies: conntrack and libmosquitto. Conntrack: Added to resolve a bug in Apfree-Wifidog that caused long-lived user connections to persist after logout. Libmosquitto: Integrated as a preparatory measure for future support of the MQTT protocol; implementation is still in progress. For detailed information, please refer to the release notes: https://github.com/liudf0716/apfree-wifidog/releases/tag/7.10.2082. Additionally, a new /etc/wifidogx directory has been created to store the local authentication portal page for users uploading their own portal pages. Signed-off-by: Dengfeng Liu <[email protected]>
liudf0716
force-pushed
the
wifidogx-master
branch
from
0013771
to
6ab1788
Compare
Maintainer: @liudf0716
Compile tested: x86_64
Run tested: x86_64
Description:
https://github.com/liudf0716/apfree-wifidog/releases/tag/7.10.2082
Dengfeng Liu [email protected]