Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrony: add ability to parse 'maxsources' param #23791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chrony: add ability to parse 'maxsources' param #23791

wants to merge 1 commit into from
+4 −2

Conversation

Npeca75
Copy link
Contributor

@Npeca75 Npeca75 commented Apr 1, 2024

Description:

[1] https://forum.openwrt.org/t/challenges-with-chrony-additional-parameters/192843

after patching init script, maxsources are visible in
/var/etc/chrony.d/10-uci.conf
example:

pool 0.ca.pool.ntp.org minpoll 7 maxpoll 9 maxsources 2 iburst

@Npeca75 Npeca75 changed the title chrony: add abbility to parse 'maxsources' param chrony: add ability to parse 'maxsources' param Apr 1, 2024
@Npeca75 Npeca75 force-pushed the chrony branch 3 times, most recently from 269ccef to fce8550 Compare April 4, 2024 04:02
@systemcrash
Copy link
Contributor

looks good to me

@BKPepe
Copy link
Member

BKPepe commented Oct 29, 2024

Let's bring here maintainer of chrony: @mlichvar

@mlichvar
Copy link
Contributor

It looks good to me. It just needs an update to fix the conflict with the package version/release.

@systemcrash
Copy link
Contributor

@Npeca75 can you rebase on the latest master please?

@Npeca75 Npeca75 force-pushed the chrony branch 2 times, most recently from 7deccf8 to 523a5ed Compare October 30, 2024 05:16
@Npeca75
Copy link
Contributor Author

Npeca75 commented Oct 30, 2024

@Npeca75 can you rebase on the latest master please?

hi @mlichvar , @systemcrash

rebased as you sugested, but for some reason, it is failing on tests
any idea ?

@mlichvar
Copy link
Contributor

To me that looks like an unrelated issue.

@Npeca75
Copy link
Contributor Author

Npeca75 commented Oct 30, 2024

To me that looks like an unrelated issue.

looking at log end ...

2024-10-30T05:37:39.0397757Z install -m0755 /builder/build_dir/target-aarch64_generic_musl/chrony-normal/chrony-4.6.1/chronyc /builder/build_dir/target-aarch64_generic_musl/chrony-normal/chrony-4.6.1/.pkgdir/chrony/usr/bin
2024-10-30T05:37:39.0428224Z install -m0755 ./files/chrony.ntp-hotplug /builder/build_dir/target-aarch64_generic_musl/chrony-normal/chrony-4.6.1/.pkgdir/chrony/usr/sbin/chrony-hotplug
2024-10-30T05:37:39.0453485Z install: cannot stat './files/chrony.ntp-hotplug': No such file or directory
2024-10-30T05:37:39.0456547Z make[2]: *** [Makefile:113: /builder/build_dir/target-aarch64_generic_musl/chrony-normal/chrony-4.6.1/.pkgdir/chrony.installed] Error 1

ntp-hotplug ?

but since i did not touched that file or anything similar ... looks like build system error

@BKPepe
Copy link
Member

BKPepe commented Oct 30, 2024

Build system error for 4 platfoms? Nah. Something is definitely wrong.

@mlichvar
Copy link
Contributor

That's odd.

The ntp-hotplug file is still in the repository: https://github.com/openwrt/packages/blob/master/net/chrony/files/chrony.ntp-hotplug

The package passed the tests two weeks ago #25157, but this PR is not changing anything in the Makefile except the release number.

@mlichvar
Copy link
Contributor

It seems the working directory has changed for some reason and all the relative paths starting with ./files/ in the Makefile are wrong. I suspect other packages might be impacted.

The failing build has

make[2]: Entering directory '/feed/net/chrony/files'

and the successful build has:

make[2]: Entering directory '/feed/net/chrony'

@systemcrash
Copy link
Contributor

This package is not to blame. Ci is just having a day today. Every build log fails in some random place if it isn’t truncated for being too long.

@Npeca75
chrony: add ability to parse 'maxsources' param
178a34f 
description:

[1] https://forum.openwrt.org/t/challenges-with-chrony-additional-parameters/192843

after patching init script, maxsources are visible in
/var/etc/chrony.d/10-uci.conf
example:
pool 0.ca.pool.ntp.org minpoll 7 maxpoll 9 maxsources 2 iburst

Signed-off-by: Peca Nesovanovic <[email protected]>
@Npeca75
Copy link
Contributor Author

Npeca75 commented Oct 31, 2024

@systemcrash @mlichvar @BKPepe

it is OK now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systemcrash systemcrash systemcrash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Npeca75 @systemcrash @BKPepe @mlichvar