-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chrony: add ability to parse 'maxsources' param #23791
base: master
Are you sure you want to change the base?
Conversation
269ccef
to
fce8550
Compare
looks good to me |
Let's bring here maintainer of chrony: @mlichvar |
It looks good to me. It just needs an update to fix the conflict with the package version/release. |
@Npeca75 can you rebase on the latest master please? |
7deccf8
to
523a5ed
Compare
hi @mlichvar , @systemcrash rebased as you sugested, but for some reason, it is failing on tests |
To me that looks like an unrelated issue. |
looking at log end ...
ntp-hotplug ? but since i did not touched that file or anything similar ... looks like build system error |
Build system error for 4 platfoms? Nah. Something is definitely wrong. |
That's odd. The ntp-hotplug file is still in the repository: https://github.com/openwrt/packages/blob/master/net/chrony/files/chrony.ntp-hotplug The package passed the tests two weeks ago #25157, but this PR is not changing anything in the Makefile except the release number. |
It seems the working directory has changed for some reason and all the relative paths starting with The failing build has
and the successful build has:
|
This package is not to blame. Ci is just having a day today. Every build log fails in some random place if it isn’t truncated for being too long. |
description: [1] https://forum.openwrt.org/t/challenges-with-chrony-additional-parameters/192843 after patching init script, maxsources are visible in /var/etc/chrony.d/10-uci.conf example: pool 0.ca.pool.ntp.org minpoll 7 maxpoll 9 maxsources 2 iburst Signed-off-by: Peca Nesovanovic <[email protected]>
@systemcrash @mlichvar @BKPepe it is OK now |
Description:
[1] https://forum.openwrt.org/t/challenges-with-chrony-additional-parameters/192843
after patching init script, maxsources are visible in
/var/etc/chrony.d/10-uci.conf
example: