Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added meeting data #15

Closed
wants to merge 1 commit into from
Closed

added meeting data #15

wants to merge 1 commit into from

Conversation

Mearnest
Copy link
Collaborator

@Mearnest Mearnest commented Jan 22, 2017

Aggregated rest of the meetings. Added two fields for building info and website url. Changed meeting_type model to add new fields.

After merch and pull, you will have to run:

mix ecto.drop
mix ecto.create
mix ecto.migrate
mix run priv/repo/seeds.exs

Tried to have seeds do the dropping for you, but something with the foreign keys and id auto incrementing caused a problem with the joining the meeting tables (lot less than should be).

Oh, forgot to prettify the JSON again.

@@ -7,14 +7,16 @@ defmodule Meetings.MeetingType do
field :title, :string
field :description, :string
field :location, :string
field :building, :string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the building field for? And is it common enough in meetings that it constitutes having a field in the main schema? Or could this be something covered with meeting_extra?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The building information was part of location, but sometimes that doesn't work in google maps, so I took it off and put it in it's own field. Most of the locations have building information, that's why it's not in extras.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll move building and website information over to extras so that the MeetingType model doesn't need to change. We can get rid of this branch. I'll rebranch with prettified json for the next pull request.

"value": "http://www.wichita.gov/Government/Departments/Planning/AgendasMinutes/{0}-{1}-{2}%20Subdivision%20Agenda%20-%20Plat%20drawings.pdf"
}
]
[{"id":"1","tid":"1","name":"agenda final","value":"http:\/\/www.wichita.gov\/Government\/Council\/Agendas\/{0}-{1}-{2}%20Final%20City%20Council%20Agenda%20Packet.pdf"}, {"id":"2","tid":"2","name":"plat drawings","value":"http:\/\/www.wichita.gov\/Government\/Departments\/Planning\/AgendasMinutes\/{0}-{1}-{2}%20Subdivision%20Agenda%20-%20Plat%20drawings.pdf"}, {"id":"3","tid":"26","name":"goals","value":"http:\/\/www.wichita.gov\/Government\/Departments\/Park\/Pages\/ParkBoard.aspx"}, {"id":"4","tid":"27","name":"Bylaws","value":"http:\/\/www.wichita.gov\/LivePlay\/Bicycle\/BicycleDocuments\/WBPAB%20Bylaws.pdf"}, {"id":"5","tid":"24","name":"lunch cost","value":"$15"}, {"id":"6","tid":"17","name":"lunch","value":"$5"}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way you could run this through a json formatter? Mostly for #10.

You can do python -m json.tool priv/data/meeting_extras.json I believe. That's what I used previously.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can do that, after we decide on how to proceed here.

Copy link
Collaborator

@aaronarduino aaronarduino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough experience with the framework to give feedback on the code, yet. But generally speaking, I concur with Seth's comments.

@Mearnest
Copy link
Collaborator Author

Mearnest commented Jan 22, 2017

There is a question of how much information we really need to show on the website. I was thinking we could link from a meeting list to a full details of the meeting, so they could see a link to the website or meeting agenda, view the description, see the building information (name, floor, room #), and then anything additional.

Or maybe we don't need to link to that stuff. Just enough information to generate an ical event.

@Mearnest
Copy link
Collaborator Author

Mearnest commented Jan 23, 2017

Regarding the data model:

Necessary fields:
Title, date (year, month, day, hour, minute), and location (street address, wichita, zip)

ical conversion:
Duration: required, defaults to 60 minutes
Email: helpful to have means of contact on email calendars
Url: to meeting agenda or list of agendas

Additional:
type: machine name, made sense in Python for filtering
subtype: some meetings have several types, and the title doesn't reflect this
Description: if we want to show them an explanation of the meeting. This applies to all meetings.
Building: a lot of meetings list building name, floor and sometimes room
Website: can be lots of other information on meeting websites. All meetings have some website.

Then there's potential extra fields we can display, such as lunch cost or link to plat drawings. If this is useful. This is meeting specific.

@Mearnest Mearnest closed this Jan 23, 2017
@Mearnest Mearnest deleted the mark-branch branch January 24, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants