Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring update #1030

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Spring update #1030

wants to merge 7 commits into from

Conversation

benwalt
Copy link
Contributor

@benwalt benwalt commented Mar 21, 2023

Spring update to
Contrib/METU-NCC
some new problems (in MAT100), some bug-fixes, some wording changes

Does not include bugfix 4751 (made on a separate branch)

The new MAT100 problems are already tagged and ready to incorporate into the main problem library (I wrote these to cover gaps in current library, so I think they are good additions).

benwalt and others added 7 commits March 21, 2023 13:22
this wasn't supposed to be included...
this wasn't supposed to be included...
This wasn't supposed to be included...
Copy link
Sponsor Member

@drdrew42 drdrew42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions! I have made a few comments, mostly FYI stuff, hopefully you find the suggestions useful.

Contrib/METU-NCC/Linear_Algebra/2.1.8.pg Show resolved Hide resolved
## Author(Benjamin Walter)
## Level(3)
## KEYWORDS('linear algebra','vectors')
## MO(1)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem does not use MathObjects. A Context is chosen, but none of the variables are actually MathObjects (making the context irrelevant).

Contrib/METU-NCC/Linear_Algebra/2.1.8.pg Show resolved Hide resolved
@@ -12,15 +12,15 @@
## Level(2)
## MO(1)
## Static(0)
## KEYWORDS('algebra', 'matrix operation', 'matrix', 'determinant')
# KEYWORDS('algebra', 'matrix operation', 'matrix', 'determinant')
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag line should retain its double-#


Context("Numeric");
#Context()->constants->remove(pi);
Context()->variables->add(pi=>['Real',TeX=>"\pi"]);
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine that your aim here is to avoid allowing students to enter decimal approximations for the solutions. You can accomplish the same thing without adding pi as a variable:

Parser::Number::NoDecimals();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants