Computer Vision live camera #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isolate was being fidgety about transferring the Status over isolate barriers. Timestamp needs to be kept inside the graph runner and then recovered so that when switching from camera and live image you always get the latest timestamp.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 479 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 214 | 1 | 264 | 0 |
Click to see the invalid file list
- openvino_bindings/src/utils/input_devices.h
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 26.63% 35.16% +8.52%
==========================================
Files 111 43 -68
Lines 4907 1914 -2993
==========================================
- Hits 1307 673 -634
+ Misses 3600 1241 -2359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Linter Add none as camera device option Fix cameraDevices list not working
RHeckerIntel
requested review from
ArendJanKramer,
ActiveChooN and
AlexanderBarabanov
as code owners
Show model loading animation during transition GraphRunner::closeCamera can be triggered twice which might cause a race condition. Instead of fixing this properly with a mutex in C++ I just eat the error code. If there was a previous provider make sure we close the camera before loading a new one. This ensures that the camera is ready to be used again when the model is loaded.
The integration test got an error onCancel after dispose. The download is still in progress after the token is cancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds camera selection for computer vision.
Code is still rough, but wanted to open PR.
Important implementation detail: Framerate shown on screen is min(inference speed, camera framerate). No intrapolation or any other techniques. Slow models will mean slow framerate.