phi-3 vision notebook #2203
Merged
phi-3 vision notebook #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB aleksandr-mokrov commented on 2024-07-17T18:11:20Z inference device s arguments Must be misprint |
|
View / edit / reply to this conversation on ReviewNB aleksandr-mokrov commented on 2024-07-17T18:11:21Z Line #3. # Uncomment these lines to see model inference class code We can be more specific: Uncomment below lines to see the model inference class code |
aleksandr-mokrov
approved these changes
Jul 22, 2024
| from transformers.modeling_outputs import CausalLMOutputWithPast, BaseModelOutputWithPast | ||
| from transformers import AutoConfig | ||
|
|
||
| from typing import Optional, Tuple, List |
There was a problem hiding this comment.
There already is typing several lines above. And it's better to put imports in order (standard libraries, related third party imports and local )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.