Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft-optical-flow #1051

Closed

Conversation

yangsu2022
Copy link

Hi @raymondlo84 @eaidova
This is my new PR.
The old one: #966

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@paularamo
Copy link
Contributor

@yangsu2022 Please rename this PR.

@yangsu2022 yangsu2022 changed the title first raft-optical-flow May 16, 2023
@eaidova eaidova added the new notebook new jupyter notebook label May 17, 2023
@ryanloney
Copy link
Contributor

I tried running on Arc A770 dGPU and this is where it fails:
image

@review-notebook-app
Copy link

review-notebook-app bot commented May 19, 2023

View / edit / reply to this conversation on ReviewNB

OpenVINO-dev-contest commented on 2023-05-19T06:06:13Z
----------------------------------------------------------------

Can you correct the ERROR message here ?


@review-notebook-app
Copy link

review-notebook-app bot commented May 19, 2023

View / edit / reply to this conversation on ReviewNB

OpenVINO-dev-contest commented on 2023-05-19T06:06:14Z
----------------------------------------------------------------

Line #11.        :param W: width of model input

Please align the parameters with its definition: H->h


@review-notebook-app
Copy link

review-notebook-app bot commented May 19, 2023

View / edit / reply to this conversation on ReviewNB

OpenVINO-dev-contest commented on 2023-05-19T06:06:15Z
----------------------------------------------------------------

can we use output_layer defined previous to get the output value ?


@review-notebook-app
Copy link

review-notebook-app bot commented May 19, 2023

View / edit / reply to this conversation on ReviewNB

OpenVINO-dev-contest commented on 2023-05-19T06:06:16Z
----------------------------------------------------------------

Line #6.        RY = 15

Shall we add some comments on what these parameters means ?


@review-notebook-app
Copy link

review-notebook-app bot commented May 19, 2023

View / edit / reply to this conversation on ReviewNB

OpenVINO-dev-contest commented on 2023-05-19T06:06:17Z
----------------------------------------------------------------

Pls fix the ERROR in log message


@review-notebook-app
Copy link

review-notebook-app bot commented May 19, 2023

View / edit / reply to this conversation on ReviewNB

OpenVINO-dev-contest commented on 2023-05-19T06:06:18Z
----------------------------------------------------------------

Line #56.                Batch, Channel, height, width = compiled_model.input(0).shape

How about wrap these openvino's function in a Class, then we can reuse it in image and video test. You have already use N, C, H, W = input_layer.shape to get the input information before, shall we unify them ?


@yangsu2022
Copy link
Author

I tried running on Arc A770 dGPU and this is where it fails: image

Yes, OV22.3 not support 7D tensor on GPU, which fixed with OV23.0.
https://jira.devtools.intel.com/browse/CVS-100599?jql=text%20~%20%22raft%22

@ryanloney
Copy link
Contributor

@yangsu2022 sorry, I was running in wrong env. I tried with pre-release 23.0 and it's running on GPU now.

BTW why is benchmark_app run twice in the notebook?

Here is what I'm seeing for Arc A770 dGPU benchmark:
image

Unfortunately this is what the visualization looks like when running on iGPU and dGPU:
image

image

I'm using 2023.0.0.dev20230427 from PyPI

Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jul 17, 2024
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new notebook new jupyter notebook Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants