[GHA] Fix Keras3 backend job for test-exclusion mechanism#36736
Open
goyaladitya05 wants to merge 1 commit into
Open
[GHA] Fix Keras3 backend job for test-exclusion mechanism#36736goyaladitya05 wants to merge 1 commit into
goyaladitya05 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Keras 3 backend GitHub Actions job to align with Keras’ newer test-exclusion mechanism (test-level exclusions applied via conftest.py), and moves the workflow off an old pinned Keras commit so the job behavior matches current Keras/OpenVINO backend expectations.
Changes:
- Bump the pinned
keras-team/kerascommit SHA used by the workflow. - Remove workflow-side
--ignoreexpansion fromexcluded_tests.txtand rely on Keras’excluded_concrete_tests.txthandling inconftest.py.
Contributor
Author
|
Hi @rkazants @openvinotoolkit/openvino-ci-maintainers, could you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Keras replaced its file-level excluded_tests.txt with a test-level excluded_concrete_tests.txt applied via conftest.py in keras-team/keras/pull/22630, since we have almost complete operator coverage for OpenVINO as a backend now (most of the implementations tracked in #34017) . The GHA job still pinned Keras to a very old commit and ran the old logic.
AI Assistance: