[GPU] Fix coverity issue #32531
Merged
[GPU] Fix coverity issue #32531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ddykim
approved these changes
Oct 24, 2025
| if (is_number(lhs) && is_number(rhs)) { | ||
| auto rhs_val = as_number<int64_t>(rhs); | ||
| OPENVINO_ASSERT(rhs_val != 0, "Modulo by zero detected in operator%"); | ||
| if (rhs_val == 1 || rhs_val == -1) { |
There was a problem hiding this comment.
I don't see any overflow issue here, is this really not a false positive?
There was a problem hiding this comment.
To get INT64_MIN % -1, the program first does INT64_MIN / -1, which gives +2^63. But that number is too big for an int64_t, so it overflows. We need to handle 1 and -1 anyway. Previously, we used strings for exceptions, but now it's changed to use numbers. Indeed, I don’t think this issue will actually happen, but Coverity still flags it as a problem.
isanghao
reviewed
Oct 27, 2025
+ Fix int64_t overflow sink
jade-cho
force-pushed
the
fix_coverity_issue3
branch
from
eb911bf to
0815f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: