-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[CPU] Fix Alibaba-NLP accuracy issue #32507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[CPU] Fix Alibaba-NLP accuracy issue #32507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an accuracy issue in the Alibaba-NLP model by adding validation to the MLP fusion pass. The fix ensures that the gate (activation) branch and up branch are correctly positioned as the first and second inputs of the Multiply node respectively before allowing fusion.
Key changes:
- Added input validation logic to verify the gate branch is connected to input0 and the up branch to input1
- Prevents incorrect fusion when VariadicSplit output ports are mismatched
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e205821 to
b7ff7b3
Compare
|
Hi @chenhu-wang could you please take a review? Thanks! |
|
Please add corresponding subgraph tests to ensure the expected un-fusing behavior is conducted correctly. |
…dicSplit output ports
b7ff7b3 to
7b923c8
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/x64/mlp_fusion.cpp
Show resolved
Hide resolved
src/plugins/intel_cpu/src/transformations/cpu_opset/x64/pass/mlp_fusion.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_cpu/src/transformations/cpu_opset/x64/pass/mlp_fusion.cpp
Show resolved
Hide resolved
7b923c8 to
fd017c0
Compare
Details:
Tickets: