Skip to content

Conversation

@liubo-intel
Copy link
Contributor

Details:

  • Fix Alibaba-NLP accuracy issue: avoid fusing MLP with unmatched VariadicSplit output ports

Tickets:

@liubo-intel liubo-intel requested review from a team as code owners October 22, 2025 04:36
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Oct 22, 2025
@yuxu42 yuxu42 requested a review from Copilot October 22, 2025 05:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an accuracy issue in the Alibaba-NLP model by adding validation to the MLP fusion pass. The fix ensures that the gate (activation) branch and up branch are correctly positioned as the first and second inputs of the Multiply node respectively before allowing fusion.

Key changes:

  • Added input validation logic to verify the gate branch is connected to input0 and the up branch to input1
  • Prevents incorrect fusion when VariadicSplit output ports are mismatched

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@liubo-intel liubo-intel force-pushed the liubo/fix_Alibaba-NLP_acc_issue branch from e205821 to b7ff7b3 Compare October 22, 2025 05:17
@yuxu42
Copy link
Contributor

yuxu42 commented Oct 23, 2025

Hi @chenhu-wang could you please take a review? Thanks!

@xuchen-intel
Copy link
Contributor

Please add corresponding subgraph tests to ensure the expected un-fusing behavior is conducted correctly.

@maxnick maxnick added the pr: needs tests PR needs tests updating label Oct 24, 2025
@liubo-intel liubo-intel force-pushed the liubo/fix_Alibaba-NLP_acc_issue branch from b7ff7b3 to 7b923c8 Compare October 24, 2025 11:06
@liubo-intel
Copy link
Contributor Author

Please add corresponding subgraph tests to ensure the expected un-fusing behavior is conducted correctly.

Done

@liubo-intel liubo-intel requested a review from Copilot October 25, 2025 11:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liubo-intel liubo-intel force-pushed the liubo/fix_Alibaba-NLP_acc_issue branch from 7b923c8 to fd017c0 Compare October 25, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: CPU OpenVINO CPU plugin pr: needs tests PR needs tests updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants