[Snippets][CPU][DEBUG_CAPS] Implement RegPrinter for ARM64 #32124
+324
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aobolensk
requested review from
ValentinaKats
and removed request for
a team
github-actions
bot
added
category: CPU
aobolensk
changed the title
tsavina
reviewed
Sep 18, 2025
| } // namespace | ||
|
|
||
| template <typename T> | ||
| void RegPrinter::print_reg_prc(const char* name, const char* ori_name, T* ptr) { |
There was a problem hiding this comment.
ori_name -> orig_name is better abbreviation for original
Comment on lines
18
to
20
| // 1. Include this header in AArch64 JIT kernels when register printing is required. | ||
| // 2. Invoke RegPrinter::print method with a supported register/precision combination. | ||
| // Examples: |
There was a problem hiding this comment.
Suggested change
| // 1. Include this header in AArch64 JIT kernels when register printing is required. | |
| // 2. Invoke RegPrinter::print method with a supported register/precision combination. | |
| // Examples: | |
| // 1. Include this header in AArch64 JIT kernels if register printing is required. | |
| // 2. Invoke the RegPrinter::print method with a supported register/precision combination. | |
| // Examples: |
v-Golubev
approved these changes
Sep 19, 2025
Comment on lines
+40
to
+50
| inline const char* get_original_name(const VReg& reg) { | ||
| return vreg_names[reg.getIdx()]; | ||
| } | ||
|
|
||
| inline const char* get_original_name(const XReg& reg) { | ||
| return xreg_names[reg.getIdx()]; | ||
| } | ||
|
|
||
| inline const char* get_original_name(const WReg& reg) { | ||
| return wreg_names[reg.getIdx()]; | ||
| } |
There was a problem hiding this comment.
Minor: maybe we can make a common template method with reg remplate parameter?
| } | ||
|
|
||
| template <typename PRC_T, size_t vlen> | ||
| void RegPrinter::print_vmm_prc(const char* name, const char* orig_name, PRC_T* ptr) { |
There was a problem hiding this comment.
Minor: it looks like print_vmm_prc and print_reg_prc are ISA agnostic and can be reused in both X64 and aarch64 RegPrinter
There was a problem hiding this comment.
I'm not sure what we can do with that at this point, since we don't have any common space for x64 & aarch64 debug caps
| void RegPrinter::print_vmm(jit_generator_t& h, const REG_T& vmm, const char* name) { | ||
| preamble(h); | ||
|
|
||
| const size_t vmm_bytes = vmm.getBit() / 8; |
There was a problem hiding this comment.
Suggested change
| const size_t vmm_bytes = vmm.getBit() / 8; | |
| const size_t vmm_bytes = vmm.getBit() / CHAR_BIT; |
| void RegPrinter::print_reg(jit_generator_t& h, const REG_T& reg, const char* name) { | ||
| preamble(h); | ||
|
|
||
| const size_t reg_bytes = reg.getBit() / 8; |
There was a problem hiding this comment.
Suggested change
| const size_t reg_bytes = reg.getBit() / 8; | |
| const size_t reg_bytes = reg.getBit() / CHAR_BIT; |
tsavina
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets: