Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed C++ RTTI for Core base classes #28640

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Fixed C++ RTTI for Core base classes #28640

merged 5 commits into from
Jan 24, 2025

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov
Fixed C++ RTTI for Core base classes (openvinotoolkit#28555)
1e9a7e8 
Android support:

<img width="200" alt="{ABD03686-78FD-4F33-A2E8-C3BE1C030D5C}"
src="https://github.com/user-attachments/assets/55bb0600-4f14-448c-b4be-e1e97e354859"
/>

in header files threated as an inline definition, which typically
results in a "weak" symbol
"weak"  symbols are not exported from dll/so libs.

To make these symbols "strong", we moved the definitions to ".cpp"
files.
@ilya-lavrenov
Fixed C++ RTTI for header only classes (openvinotoolkit#28624)
46b5ed1 
### Details:
- Regression after
openvinotoolkit#28555
@ilya-lavrenov
Fixed more C++ RTTI on macOS
28aa5d9
@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Jan 23, 2025
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners January 23, 2025 12:35
@ilya-lavrenov ilya-lavrenov requested review from PiotrKrzem, cavusmustafa and itikhono and removed request for a team January 23, 2025 12:35
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: Python API OpenVINO Python bindings category: transformations OpenVINO Runtime library - Transformations category: LP transformations OpenVINO Low Precision transformations category: CI OpenVINO public CI category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: CPP API OpenVINO CPP API bindings github_actions Pull requests that update GitHub Actions code category: PyTorch FE OpenVINO PyTorch Frontend labels Jan 23, 2025
@github-actions github-actions bot added category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: JAX FE OpenVINO JAX FrontEnd labels Jan 23, 2025
@itikhono
Copy link
Contributor

do we need to port also this commit 0389fd6?

@github-actions github-actions bot added the category: build OpenVINO cmake script / infra label Jan 23, 2025
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Jan 24, 2025
Merged via the queue into openvinotoolkit:releases/2025/0 with commit 815af98 Jan 24, 2025
186 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
@ilya-lavrenov
Fixed C++ RTTI for Core base classes (#28640)
815af98 
### Ported:
- #28555
- #28624
- #28636
@ilya-lavrenov ilya-lavrenov deleted the cpp-rtti branch January 24, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants left review comments

@praasz praasz praasz approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@olpipi olpipi olpipi approved these changes

@itikhono itikhono itikhono approved these changes

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees

@t-jankowski t-jankowski

@praasz praasz

Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: JAX FE OpenVINO JAX FrontEnd category: LP transformations OpenVINO Low Precision transformations category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd category: transformations OpenVINO Runtime library - Transformations Code Freeze github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ilya-lavrenov @itikhono @olpipi @rkazants @t-jankowski @praasz @moslex