Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Op] ISTFT op class, shape infer and reference #28606

Merged
merged 49 commits into from
Feb 5, 2025
Merged

[Op] ISTFT op class, shape infer and reference #28606

merged 49 commits into from
Feb 5, 2025

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Jan 22, 2025 •
edited
Loading

Details:

  • ISTFT op class and
  • ISTFT shape inference (tested by type_prop, CPU registration and CPU shape infer tba with CPU enablement PR)
  • ISTFT reference implementation

Tickets:

  • 159379, 159380

Related PRs:

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Jan 22, 2025
@github-actions github-actions bot added the category: TEMPLATE OpenVINO Template plugin label Jan 24, 2025
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Jan 28, 2025
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Jan 29, 2025
@github-actions github-actions bot removed the category: PyTorch FE OpenVINO PyTorch Frontend label Jan 30, 2025
@mitruska mitruska changed the title [WIP][Op] ISTFT op class and shape inference [Op] ISTFT op class, shape infer and reference Jan 30, 2025
@mitruska mitruska marked this pull request as ready for review January 30, 2025 07:55
@mitruska mitruska requested review from a team as code owners January 30, 2025 07:55
praasz
praasz reviewed Feb 4, 2025
View reviewed changes
src/core/include/openvino/op/istft.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/op/istft.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/op/istft.hpp Show resolved Hide resolved
src/core/reference/src/op/istft.cpp Outdated Show resolved Hide resolved
src/core/reference/src/op/istft.cpp Outdated Show resolved Hide resolved
src/core/tests/visitors/op/istft.cpp Outdated Show resolved Hide resolved
src/plugins/template/backend/ops/istft.cpp Show resolved Hide resolved
src/core/shape_inference/include/istft_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/src/op/istft.cpp Outdated Show resolved Hide resolved
src/core/reference/src/op/istft.cpp Outdated Show resolved Hide resolved
mitruska added 20 commits February 4, 2025 13:55
@mitruska
Merge remote-tracking branch 'upstream/master' into mitruska/istft_op…
b26d73d 
…_class
@mitruska
Adjust namespace and remove setter
3ca319b
@mitruska
Unify norm and window to single transform
635e429
@mitruska
Use func::add instead of std::plus
06aaa44
@mitruska
Remove transpose variable
d506730
@mitruska
Move frame signal init
c8f785f
@mitruska
Adjust shape_infer namespace style
002255f
@mitruska
Use loop for in type check
01e34c7
@mitruska
Remove prefix in type_prop tests
128feb7
@mitruska
Adjust tests namespaces style
16e860e
@mitruska
Use value at the end of error message in shape infer
cb5de40
@mitruska
Rename input_idx to port
edd4fb8
@mitruska
Add using Parameter, Constant in attr tests
d7d10f6
@mitruska
Adjust error message
7f060af
@mitruska
Update to use default shape
ee92f2c
@mitruska
Update only dim not the whole shape
1fb362e
@mitruska
Init result with 0
857d615
@mitruska
Reuse some variables for idx calculations
0d12e0e
@mitruska
Unify results copy in ref
02b1e89
@mitruska
Merge remote-tracking branch 'upstream/master' into mitruska/istft_op…
db70f36 
…_class
@mitruska mitruska requested a review from praasz February 5, 2025 08:18
praasz
praasz approved these changes Feb 5, 2025
View reviewed changes
src/core/reference/src/op/istft.cpp Outdated Show resolved Hide resolved
src/core/reference/src/op/istft.cpp Show resolved Hide resolved
@mitruska mitruska enabled auto-merge February 5, 2025 14:47
@mitruska mitruska added this pull request to the merge queue Feb 5, 2025
Merged via the queue into openvinotoolkit:master with commit e4611ea Feb 5, 2025
185 checks passed
@mitruska mitruska deleted the mitruska/istft_op_class branch February 5, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmikolajcz mmikolajcz mmikolajcz approved these changes

@praasz praasz praasz approved these changes

@pkowalc1 pkowalc1 Awaiting requested review from pkowalc1

@p-wysocki p-wysocki Awaiting requested review from p-wysocki

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem

Assignees

@mitruska mitruska

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IE Tests OpenVINO Test: plugins and common category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mitruska @mmikolajcz @praasz