[PDPD]Added and fixed Paddle convert. #28347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build_jenkins |
|
Hi @ceciliapeng2011 Could you please take a review? Thanks! |
| return res; | ||
| } | ||
|
|
||
| Output<Node> get_1d_tensor(const Output<Node>& node) { |
There was a problem hiding this comment.
Do you meet any problem here without inserting unsqueeze node when node_dim == 0? OpenVINO supports scalar (rank==0).
| return res; | ||
| } | ||
|
|
||
| Output<Node> get_1d_tensor(const Output<Node>& node) { |
There was a problem hiding this comment.
The name "get_1d_tensor" sounds a bit mis-leading - it does not turn any tensor to 1D, right？Suggest change to something like "get_tensor_safe".
|
build_jenkins |
ceciliapeng2011
approved these changes
Jan 20, 2025
xczhai
reviewed
Jan 21, 2025
| value_node = opset6::Constant::create(dtype, {1}, {value}); | ||
| value_node = opset6::Constant::create(dtype, {}, {value}); | ||
| } else if (dtype == element::f64) { | ||
| float value = static_cast<double>(node.get_attribute<float>("value")); |
There was a problem hiding this comment.
Suggested change
| float value = static_cast<double>(node.get_attribute<float>("value")); | |
| double value = static_cast<double>(node.get_attribute<float>("value")); |
|
It looks some windows building failure. @bukejiyu I show you the way to check the building logs. click the failed item click the failure logs |
bukejiyu
force-pushed
the
paddle_convert
branch
from
0dc5f4c to
1553492
Compare
bukejiyu
force-pushed
the
paddle_convert
branch
from
1553492 to
2f488af
Compare
|
build_jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: