Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Py OV] Initialize op and opset*/ops.py explicitly #28296

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

almilosz
Copy link
Contributor

@almilosz almilosz commented Jan 7, 2025

Details:

  • An Issue appeared after moving openvino.runtime.utils (PR28062). On openvino import, op was initialized here alongside utils. I propose to initialize op explicitly in openvino/runtime/__init__.py and openvino/__init__.py
  • Initialize ops.py in runtime/opset*/ as they are present in the sys.modules for 2024.6-openvino and some users may access operators directly from there.

Tickets:

Signed-off-by: Alicja Miloszewska <[email protected]>
Signed-off-by: Alicja Miloszewska <[email protected]>
Signed-off-by: Alicja Miloszewska <[email protected]>
@almilosz almilosz requested review from a team as code owners January 7, 2025 12:46
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: tools OpenVINO C++ / Python tools category: OVC OVC tool labels Jan 7, 2025
@almilosz almilosz requested a review from akuporos January 7, 2025 12:54
Copy link
Contributor

@KodiaqQ KodiaqQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From NNCF's side, we decided that having a validation on the reproducer is enough to merge it. Wider validation would be performed with the updated OpenVINO package after the merge.

@mlukasze mlukasze added this pull request to the merge queue Jan 8, 2025
@mlukasze
Copy link
Contributor

mlukasze commented Jan 8, 2025

From NNCF's side, we decided that having a validation on the reproducer is enough to merge it. Wider validation would be performed with the updated OpenVINO package after the merge.

ok, let's try to merge it to catch NNCF validation schedule and have buffer next week if something will need additional improvements

@ilya-lavrenov ilya-lavrenov added this to the 2025.0 milestone Jan 8, 2025
Merged via the queue into openvinotoolkit:master with commit 6c610e9 Jan 8, 2025
185 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2025
### Details:
- Bring back changes reverted here
#28190
- The original cause was fixed here
#28296
- Make sure that `sys.modules` contains all proxy modules from `runtime`
in comparison to `openvino 24.6`

### Tickets:
 - [CVS-129450](https://jira.devtools.intel.com/browse/CVS-129450)

---------

Signed-off-by: Alicja Miloszewska <[email protected]>
Co-authored-by: Anastasia Kuporosova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: OVC OVC tool category: Python API OpenVINO Python bindings category: tools OpenVINO C++ / Python tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants