Fix potential integer overflow coverity scan issue in CPU plugin subgraph implementation #28292
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raph implementation
| @@ -962,7 +962,10 @@ Subgraph::SubgraphExecutor::SubgraphExecutor(const std::shared_ptr<Subgraph::Sub | |||
| m_in_requested_descs.end(), | |||
| size_t(0), | |||
| [](size_t sum, const std::pair<size_t, ov::intel_cpu::MemoryDescPtr>& requested_desc_elem) { | |||
| return sum + requested_desc_elem.second->getCurrentMemSize(); | |||
| auto curr_mem_size = requested_desc_elem.second->getCurrentMemSize(); | |||
| OPENVINO_ASSERT(curr_mem_size != ov::intel_cpu::MemoryDesc::UNDEFINED_SIZE, | |||
There was a problem hiding this comment.
Does it really prevent possible overflow?
If we really want to throw in case of overflow, the check should look like:
OPENVINO_ASSERT(sum < sum + curr_mem_size);There was a problem hiding this comment.
Linter concern was specifically about this UNDEFINED_SIZE value, which is basically (size_t)-1. This case is checked here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: