[CPU] [TRANSFORMATIONS] FakeConvert decomposition transformation #28118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuchen-intel
added
category: CPU
github-actions
bot
added
category: IE Tests
xuchen-intel
force-pushed
the
feature/fake_convert_decomposition
branch
from
a5654fb to
7412bc2
Compare
t-jankowski
reviewed
Dec 18, 2024
...common/transformations/include/transformations/op_conversions/fake_convert_decomposition.hpp
Outdated
Show resolved
Hide resolved
praasz
reviewed
Dec 18, 2024
| const Output<Node> input_scale{fake_convert_node->input_value(1)}; | ||
| auto input_type = data.get_element_type(); | ||
|
|
||
| ov::NodeVector decomp_ops; |
There was a problem hiding this comment.
Suggested change
| ov::NodeVector decomp_ops; | |
| ov::pass::NodeRegistry decomp_ops; |
use it instead then :
if (input_type != input_scale.get_element_type()) {
input_type = input_scale.get_element_type();
decomp_ops.make<ov::op::v0::Convert>(data, input_type); // it returns created node which can be used later if required
}
/// at end
ov::copy_runtime_info(fake_convert_node, decomp_ops.get());There was a problem hiding this comment.
Applied. Thanks Pawel!
| bool default_shift; | ||
| std::tie(data_shape, scale_shape, shift_shape, data_prec, dst_prec, default_shift) = params; | ||
|
|
||
| std::shared_ptr<ov::Model> f(nullptr); |
There was a problem hiding this comment.
Suggested change
| std::shared_ptr<ov::Model> f(nullptr); | |
| std::shared_ptr<ov::Model> model; |
Detail: use model instead f
There was a problem hiding this comment.
Applied. Thanks Pawel!
| manager.register_pass<ov::pass::FakeConvertDecomposition>(); | ||
| manager.run_passes(f); | ||
|
|
||
| OV_ASSERT_NO_THROW(check_rt_info(f)); |
There was a problem hiding this comment.
Can test be added in test body instead test's setup?
There was a problem hiding this comment.
Applied. Thanks Pawel!
xuchen-intel
changed the title
xuchen-intel
force-pushed
the
feature/fake_convert_decomposition
branch
2 times, most recently
from
5690a3e to
13dbba9
Compare
|
@praasz @t-jankowski Hi Pawel and Tomasz, do you have more comments? |
|
@dmitry-gorokhov Hi Dmitry, could you please also take a look? |
xuchen-intel
force-pushed
the
feature/fake_convert_decomposition
branch
from
13dbba9 to
f5b166a
Compare
github-actions
bot
removed
category: IE Tests
...common/transformations/include/transformations/op_conversions/fake_convert_decomposition.hpp
Show resolved
Hide resolved
|
@xuchen-intel Could you please also implement shared single layer test for FakeConvert operation and add its instance for CPU plugin? |
xuchen-intel
force-pushed
the
feature/fake_convert_decomposition
branch
from
f5b166a to
cd1b9a9
Compare
github-actions
bot
added
the
category: IE Tests
Applied. Thanks Dmitry! |
dmitry-gorokhov
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
Prerequisites: