Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] FullyConnected: corrected BF16 config in case of f16 weights #25214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CPU] FullyConnected: corrected BF16 config in case of f16 weights #25214

wants to merge 1 commit into from
+91 −125

Conversation

v-Golubev
Copy link
Contributor

@v-Golubev v-Golubev commented Jun 25, 2024 •
edited
Loading

Details:

  • FullyConnected executor config for bf16 data and f16 weights is aligned with bf16 data f32 weights case
  • Updated MatMulDecompressConvertTest tests

Tickets:

@v-Golubev v-Golubev requested review from a team as code owners June 25, 2024 15:42
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jun 25, 2024
@v-Golubev v-Golubev force-pushed the vg/cpu/fc_bf16_config_fix branch 3 times, most recently from 6ca99cd to 2654ef9 Compare June 26, 2024 14:18
@v-Golubev v-Golubev added this to the 2024.3 milestone Jun 28, 2024
@maxnick
Copy link
Contributor

maxnick commented Jun 28, 2024

@EgorDuplensky , could you please review?

@v-Golubev v-Golubev force-pushed the vg/cpu/fc_bf16_config_fix branch from 2654ef9 to d400f37 Compare July 1, 2024 16:07
EgorDuplensky
EgorDuplensky approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@EgorDuplensky EgorDuplensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EgorDuplensky EgorDuplensky removed their assignment Jul 2, 2024
@EgorDuplensky
Copy link
Contributor

@maxnick Ready for future steps

@v-Golubev v-Golubev force-pushed the vg/cpu/fc_bf16_config_fix branch from d400f37 to 190835d Compare July 2, 2024 15:00
@v-Golubev v-Golubev requested a review from maxnick July 2, 2024 15:08
@v-Golubev
Copy link
Contributor Author

Performance degradation was found for one of the model (the details are in the ticket). The merge is possible only if the degradation will be fixed

@v-Golubev v-Golubev force-pushed the vg/cpu/fc_bf16_config_fix branch 2 times, most recently from 12f652e to 214d290 Compare July 11, 2024 13:33
@maxnick maxnick modified the milestones: 2024.3, 2024.4 Jul 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Aug 4, 2024
@v-Golubev v-Golubev added no_stale Do not mark as stale and removed Stale labels Aug 4, 2024
@v-Golubev v-Golubev force-pushed the vg/cpu/fc_bf16_config_fix branch 2 times, most recently from 481f876 to 5a3abe7 Compare September 9, 2024 08:39
@wenjiew wenjiew modified the milestones: 2024.4, 2024.5 Oct 10, 2024
@wenjiew wenjiew modified the milestones: 2024.5, 2025.0 Nov 28, 2024
@wenjiew
Copy link

wenjiew commented Dec 16, 2024

Should we pick up this and merge it in 2025.0?

@v-Golubev v-Golubev force-pushed the vg/cpu/fc_bf16_config_fix branch from 5a3abe7 to 92aa520 Compare January 20, 2025 10:49
@ilya-lavrenov ilya-lavrenov removed this from the 2025.0 milestone Jan 23, 2025
@v-Golubev v-Golubev force-pushed the vg/cpu/fc_bf16_config_fix branch from 92aa520 to 68a97d3 Compare January 24, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxnick maxnick maxnick approved these changes

@EgorDuplensky EgorDuplensky EgorDuplensky approved these changes

Assignees

@maxnick maxnick

Labels
category: CPU OpenVINO CPU plugin do not merge no_stale Do not mark as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-Golubev @maxnick @EgorDuplensky @wenjiew @ilya-lavrenov