Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_prepare_checkpoints #827

Merged

Conversation

daniil-lyakhov
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov commented Jul 6, 2021

  • Required checkpoint path in prepare_checkpoints.py
  • Refactored test to load real checkpoints from sanity test_model_train to properly test prepare_checkpoints.py, which required checkpoint path. (It was impossible to make new small model to pass it into prepare checkpoint because prepare checkpoint can build only yolo, retinanet and maskrcnn models.)

Local check shows new version of the test small time consuming (~30 sec ~= not refactored test running time).

@daniil-lyakhov daniil-lyakhov requested review from alexsu52 and a team July 6, 2021 11:11
@daniil-lyakhov
Copy link
Collaborator Author

#682 is being considered as more important thus should be merged first
CC @ljaljushkin

@alexsu52 alexsu52 requested a review from ljaljushkin July 7, 2021 06:27
@daniil-lyakhov daniil-lyakhov force-pushed the dl/prepare_checkpoints branch from 26ed43c to d37df2c Compare July 7, 2021 06:50
@daniil-lyakhov daniil-lyakhov added the NNCF TF Pull requests that updates NNCF TensorFlow label Jul 7, 2021
@daniil-lyakhov daniil-lyakhov force-pushed the dl/prepare_checkpoints branch from 266d53f to cd875b4 Compare July 7, 2021 11:24
@alexsu52 alexsu52 merged commit 87dafda into openvinotoolkit:develop Jul 7, 2021
kshpv pushed a commit to kshpv/nncf that referenced this pull request Oct 11, 2022
* Required checkpoint path in `prepare_checkpoints.py`
* Refactored test to load real checkpoints from sanity test_model_train to properly test  `prepare_checkpoints.py`, which required checkpoint path. (It was impossible to make new small model to pass it into prepare checkpoint because prepare checkpoint can build only yolo, retinanet and maskrcnn models.) 

Local check shows new version of the test small time consuming (~30 sec ~= not refactored test running time).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants