Skip to content

swap_dir in test_framework fix for model reload#4319

Merged
porlows1 merged 1 commit into
mainfrom
porlows1_swap_dir_test_fix
Jun 23, 2026
Merged

swap_dir in test_framework fix for model reload#4319
porlows1 merged 1 commit into
mainfrom
porlows1_swap_dir_test_fix

Conversation

@porlows1

@porlows1 porlows1 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This PR adjusts the functional test framework’s swap_directory() helper to better support model reload scenarios by ensuring the target directory’s parent path exists before attempting a directory swap.
Fixes model-server.tests issues with new models export on clx6.

🛠 Summary

JIRA/Issue if applicable.
Describe the changes.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings June 23, 2026 12:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the functional test framework’s swap_directory() helper to better support model reload scenarios by ensuring the target directory’s parent path exists before attempting a directory swap.

Changes:

  • Create the target_path parent directory (if needed) before renaming staging_path into place.
  • Simplify rollback logic in the error path by removing the target_moved flag and relying on old_path existence.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread tests/functional/utils/test_framework.py
@porlows1 porlows1 merged commit 2b990fd into main Jun 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants