Skip to content

Network failure-proof the pull tests#4290

Open
rasapala wants to merge 5 commits into
mainfrom
make_pull_stable
Open

Network failure-proof the pull tests#4290
rasapala wants to merge 5 commits into
mainfrom
make_pull_stable

Conversation

@rasapala

Copy link
Copy Markdown
Collaborator

🛠 Summary

Making pull cache tests network failure proof.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings June 15, 2026 14:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves robustness of the HuggingFace pull-cache test fixture to better tolerate transient network/LFS failures when initializing the shared cached repository used by HfPullCache tests.

Changes:

  • Adds a helper to run --pull synchronously and capture the server exit code.
  • Adds retry logic (max attempts + delay) and cache integrity checks (presence + expected file sizes + absence of .lfswip markers) when initializing the shared HF cache.
  • Seeds each test’s temp repository by copying from the shared cached repository.

Comment thread src/test/pull_hf_model_test.cpp
Comment thread src/test/pull_hf_model_test.cpp
Comment thread src/test/pull_hf_model_test.cpp
rasapala and others added 2 commits June 15, 2026 16:27
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants