Mistral tool parser: ignore missing beginning of tools token #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzegla
approved these changes
Oct 30, 2025
| if (generatedTokens[0] != this->botTokenId && !immediateParsingEnabled) { | ||
| SPDLOG_LOGGER_DEBUG(llm_calculator_logger, "Begin of tools token has not been found in the model output. Exiting parser."); | ||
| return; | ||
| if (parsedOutput.content.size() >= 2 && parsedOutput.content[0] == '[' && parsedOutput.content[1] == '{') { |
Collaborator
There was a problem hiding this comment.
Can't we rely on generatedTokens? We already base on checking it in condition above, so why not keep it continuous?
Collaborator
Author
There was a problem hiding this comment.
I don't think its good idea, [{ is regular text (non special token)
Do you want me to handle all cases where:
- [ and { are separate tokens? x, y
- [{ is glued together into 1 token? x
Collaborator
There was a problem hiding this comment.
No, in that case I think it's fine.
dkalinowski
force-pushed
the
mistral-ignore-bot
branch
from
590b980 to
afeef49
Compare
dkalinowski
force-pushed
the
mistral-ignore-bot
branch
from
afeef49 to
c29ab59
Compare
dtrawins
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
This change forgives model when
[TOOL_CALL]is not generated (but expected), however (valid) generations starting with[{will be treated as tools, which is incorrectbfcl simple: 0.89->0.895
bfcl multiple: multiple 0.745->0.895