Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charging Animation, Updated Battery and Car site for Smart EQ (SQ) #175

Closed
wants to merge 124 commits into from

Conversation

zorgms
Copy link
Contributor

@zorgms zorgms commented Sep 22, 2024

Added a Charging animation inspired by request #151

for Smart EQ:
Battery site:

  • cabin and ambient temperature added
  • A/C button added, incl. A/C starting option

Car site:

  • cabin and ambient temperature listed left row
  • Energy, SoC an SoH added to the bottum row
  • fixed wrong TMPS tyre side, right left were swapped

At this time need a Dirty OVMS Firmware by @Dimitrie78 and a JS Script to show all information.

image

smart_charging

Charging screen:
Charging power in kWh
Energy in the battery
Charging current
Charging voltage

Vehicle screen:
Energy in the battery
Charging status SoC
Battery status SoH
homelink 1 = Booster
homelink 3 = Module reset
all temperatures listed on the left
Charging screen:
Charging power in kWh
Energy in the battery
Charging current
Charging voltage

Vehicle screen:
Energy in the battery
Charging status SoC
Battery status SoH
homelink 1 = Booster
homelink 3 = Module reset
all temperatures listed on the left
TPMS EQ fix, switch left <> right
some Android cfg fixes
Charging screen:
Charging power in kWh
Energy in the battery
Charging current
Charging voltage

Vehicle screen:
Energy in the battery
Charging status SoC
Battery status SoH
homelink 1 = Booster
homelink 3 = Module reset
all temperatures listed on the left
TPMS EQ fix, switch left <> right
some Android cfg fixes
Charging screen:
Charging power in kWh
Energy in the battery
Charging current
Charging voltage

Vehicle screen:
Energy in the battery
Charging status SoC
Battery status SoH
homelink 1 = Booster
homelink 3 = Module reset
all temperatures listed on the left
TPMS EQ fix, switch left <> right
some Android cfg fixes
calculated ideal range for Smart EQ (SQ)
calculated ideal range for Smart EQ (SQ)
calculated ideal range for Smart EQ (SQ)
translate wheel name for EQ to german
calculated ideal range for Smart EQ (SQ)
calculated ideal range for Smart EQ (SQ)
added for Smart EQ on battery side Cabin/Ambient temperature and A/C button
calculated ideal range for Smart EQ (SQ)
added for Smart EQ on battery side Cabin/Ambient temperature and A/C button
calculated ideal range for Smart EQ (SQ)
added for Smart EQ on battery side Cabin/Ambient temperature and A/C button
calculated ideal range for Smart EQ (SQ)
added for Smart EQ on battery side Cabin/Ambient temperature and A/C button
calculated ideal range for Smart EQ (SQ)
added for Smart EQ on battery side Cabin/Ambient temperature and A/C button
calculated ideal range for Smart EQ (SQ)
set value/state updated
@zorgms
Copy link
Contributor Author

zorgms commented Sep 22, 2024

Screenshot_20240915-174211

@zorgms zorgms marked this pull request as ready for review November 3, 2024 19:59
@zorgms
Copy link
Contributor Author

zorgms commented Nov 7, 2024

image

@dexterbg
Copy link
Member

ZorG,

as this seems to have settled a bit, I've taken a look at the current state. Lots of nice additions.

I cannot test the Smart EQ specific additions. Here are my suggestions for the general App configuration, in no specific order:

  • The new main battery SOC text color (orange) on the Info fragmet is hard to read, especially for people with visual impairments (color blindness) despite the new size. The IDE also warns about the contrast on this. I suggest reverting to plain white, which has proven to be good on both the green and the grey background. The shadow is nice & can be kept.
  • The charge time estimations boxes need to be reverted to their original size and paddings: the right box (ETR full) is higher now than the left one (90px instead of 76px), shifting the icon to below the background gradient. Also the larger text size does not allow for cars with both sufficient range & SOC displays, like for example the Twizy, and the double padding (start&end) now causes even a standard single SOC time to break into two lines. The padding should be only "paddingRight", as it's meant to leave space for the icons, and the text size needs to be 24px. Also, the text gravity needs to be centered vertically + right, to accomodate for different line counts… or, IOW, simply fully revert both boxes to their previous attributes. I think you don't need them anyway now for the Smart EQ, do you?
  • Two decimals for the 12V display seems a bit over the top…? Especially when taking into account most users won't even bother to calibrate their 12V readings…
  • The date format option is not a plugin, it's a locale config. We added the other regional prefs options (tyre pressure & temperatures) to the Car fragment's menu, so that may be an option. Or you can move all three into the global options fragment, but then under a separate label, not as "Plugins". I'm also not sure if we actually need to have this as a user option. Why not use the Android's system locale settings for this? Btw, I'd like to see this for the pressure & temperature units as well, maybe you can give that a try while you're at it?
  • The plugin & firmware update controls are currently clearly a pure developer & beta tester feature. Normal users should have the auto update enabled and only install the main releases. And the plugin controls are currently fixed & tailored for developers only. So you should clearly state their purpose in the info text below these, so normal users don't accidentally enable them and run into problems trying to use them.
  • If you actually deem some of the current Smart EQ "plugin" functions as usable by normal users (?), it's best to separate them and add them as a general menu/fragment when a Smart vehicly type is detected.

Regards,
Michael

@zorgms
Copy link
Contributor Author

zorgms commented Dec 31, 2024

I could certainly undo some changes and adjust others, but there are too many things that have been changed in the last three months. A note in between would have helped. Now I'm withdrawing my change request with regard to #177 , as the new UI is much better positioned and my adjustments would have to be implemented there first, so it's simply no longer worth adjusting anything.

Regards,
Michael

@zorgms zorgms closed this Dec 31, 2024
@developerfromjokela
Copy link
Contributor

developerfromjokela commented Dec 31, 2024

I could certainly undo some changes and adjust others, but there are too many things that have been changed in the last three months. A note in between would have helped. Now I'm withdrawing my change request with regard to #177 , as the new UI is much better positioned and my adjustments would have to be implemented there first, so it's simply no longer worth adjusting anything.

Regards, Michael

You're welcome to do image files for smart EQ, they're still missing from new release.

It needs doors, charging port, cable plugged in, etc. There's still work to be done for each model :)

New way of rendering allows doors to be shown as open, etc. Not only highlighting by red overlay like before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants