Fix phonetics for 露 #577
Merged
Fix phonetics for 露 #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `露 ㄌㄨˋ` variant from concise dictionary preferences. `露馬腳 ㄌㄡˋ ㄇㄚˇ ㄐㄧㄠˇ` is the only `露 ㄌㄡˋ` been added. Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E9%9C%B2#searchL
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Source/Data/BPMFMappings.txt: Language not supported
- Source/Data/phrase.occ: Language not supported
Code Review Agent Run #77950aActionable Suggestions - 0Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
lukhnos
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
露 ㄌㄨˋvariant from concise dictionary preferences.露馬腳 ㄌㄡˋ ㄇㄚˇ ㄐㄧㄠˇis the only露 ㄌㄡˋbeen added.Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E9%9C%B2#searchL
Summary by Bito
Enhancement of phonetic mapping system by adding variant pronunciation '˜ㄨˋ' for the character '露' and its compound words. Updates include new entries in BPMFMappings.txt for compound words containing '露' with their phonetic notations, and corresponding occurrence data updates in phrase.occ file.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2