Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phonetics for 化 #576

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Fix phonetics for 化 #576

merged 1 commit into from
Feb 2, 2025

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Jan 31, 2025

化子 ㄏㄨㄚ ㄗ˙ is the only phrase with 化 ㄏㄨㄚ from the concise dictionary.

Add phrases from the concise dictionary.

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%8C%96&size=-1

Summary by Bito

Added 16 new phrases containing '化' (hua4) to the phonetic mapping database with corresponding Bopomofo notations. Includes phrases like '化學治療', '文化村', and '透明化'. All new entries initialized with zero occurrence count in tracking file.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

`化子 ㄏㄨㄚ ㄗ˙` is the only phrase with `化 ㄏㄨㄚ` from the concise dictionary.

Add phrases from the concise dictionary.

Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%8C%96&size=-1
@Copilot Copilot bot review requested due to automatic review settings January 31, 2025 15:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • Source/Data/BPMFMappings.txt: Language not supported
  • Source/Data/phrase.occ: Language not supported
Copy link

bito-code-review bot commented Jan 31, 2025

Code Review Agent Run #05087d

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: cecadac..cecadac
    • Source/Data/BPMFMappings.txt
    • Source/Data/phrase.occ
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful

AI Code Review powered by Bito Logo

Copy link

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Enhanced Chinese Phonetic Mappings

BPMFMappings.txt - Added 16 new Chinese character phrases with phonetic mappings for '化'

phrase.occ - Added occurrence count entries for 16 new phrases containing '化'

@lukhnos lukhnos merged commit ec9fb37 into openvanilla:master Feb 2, 2025
1 check passed
@xatier xatier deleted the hua4 branch February 2, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants